AutoTop DIY

[JayG]

Originally Posted by Polaris

The MovementCount veritable should definitely be getting set to either openTime or closeTime depending on the button pressing. Maybe I posted the wrong version of the code....like a bone head. I'll have a look through my files when I get home from work.

Thanks

I have brain farts all the time

[Polaris]

well craptastic. Looks like the final version got overwritten with the second to last version. I'll go over the code and figure it out and let you know.

On a side note, they are sending me "another" ftdi friend as it's now been 20 days since I ordered the previous one. Looks like USPS ate it.

[JayG]

Thanks, I appreciate it

[Polaris]

I'm pretty sure the last switch statement should just look like:

default: //no movement currently
if(openBtnCount > 0) {
openMode = 1;
movementCount = openTime;
digitalWrite(closeBtnOut, LOW);
digitalWrite(openBtnOut, HIGH);
} else if(closeBtnCount > 0) {
openMode = 2;
movementCount = closeTime;
digitalWrite(closeBtnOut, HIGH);
digitalWrite(openBtnOut, LOW);
} else {
allStop();
}

I'm also pretty sure the "movementCount -= loopInterval;" lines shouldn't be in the case 3 and case 4 and default switches. They are unnecessary in case 3 and 4, and constantly decremented when there is no motion in the default case.

[JayG]

Originally Posted by Polaris

I'm pretty sure the last switch statement should just look like:

default: //no movement currently
if(openBtnCount > 0) {
openMode = 1;
movementCount = openTime;
digitalWrite(closeBtnOut, LOW);
digitalWrite(openBtnOut, HIGH);
} else if(closeBtnCount > 0) {
openMode = 2;
movementCount = closeTime;
digitalWrite(closeBtnOut, HIGH);
digitalWrite(openBtnOut, LOW);
} else {
allStop();
}

I'm also pretty sure the "movementCount -= loopInterval;" lines shouldn't be in the case 3 and case 4 and default switches. They are unnecessary in case 3 and 4, and constantly decremented when there is no motion in the default case.

just tried those changes and the output still does not stay high except for the time when the switch is closed, in other words no auto operation.

I am using the onboard LED (pin 13) as the output for testing as it is easier than uploading the code and installing in the car to test

[Polaris]

do you still have your delay(50) removed?

[Polaris]

...and delay(50) should be delay(loopInterval)

[JayG]

Originally Posted by Polaris

...and delay(50) should be delay(loopInterval)

The delay is active

I did add the highlighted lines and it appears to now work.
I do have to install it and see for sure

switch(openMode) { ////0=no auto movement, 1=auto open, 2 = auto close, 3 = manual open, 4 = manual close
case 1: //currently auto-opening
digitalWrite(openBtnOut, HIGH);
movementCount -= loopInterval;

and

case 2: //currently auto-closing
digitalWrite(closeBtnOut, HIGH);
movementCount -= loopInterval;

with those 2 extra lines of code, it does auto open/close and a press of the opposite direction button will immediate stop and a press longer than shortPressInterval of the same direction button will stop it

[Polaris]

If you are going to write high there, you need to also write low to the other pin so you don't accidentally have both open and close high at the same time...that would be dangerous.

[Polaris]

Ooh! I just found my old Nano with onboard USB. I'll set it up and test the code and add support for the parking break pin, too.

I'm not seeing why you needed to add the lines to case 1 and case 2. The pins get written high in the default case before switching to case 1 or 2. Without the default case writing the pin high, the case 1 or case 2 won't be run until the second time around the loop, 50ms later since the default case is what sets the openMode to 1 or 2.

[JayG]

Originally Posted by Polaris

Ooh! I just found my old Nano with onboard USB. I'll set it up and test the code and add support for the parking break pin, too.

I'm not seeing why you needed to add the lines to case 1 and case 2. The pins get written high in the default case before switching to case 1 or 2. Without the default case writing the pin high, the case 1 or case 2 won't be run until the second time around the loop, 50ms later since the default case is what sets the openMode to 1 or 2.

I was just trying a few things. I am very new to programming these things, so it is highly likely unneeded code. Without the added lines it did not run in auto mode at all. The output was high only as long as the switch was closed. A short push did not enable auto mode.

In any case, I'll wait for you to test, especially with the e brake support

Thanks

[Pitbull-rc]

Hi Polaris,
Do you still make them? I would love to order one!
Kind regards,
Rene

[Polaris]

Success!!!

I found the correct final sketch, and I updated it to include a parking brake pin on pin 4.

I'm a little weary about the parking break pin simply because it doesn't require an extra lock-out on the parking brake so it'll operate when somebody presses the button at any speed...in other words, use it at your own risk.

I updated the link to the code in the original post. Also, a side note, the link goes directly to the .ino sketch, but since there is no defined MIME for that extension, it just shows it as text. You should be able to right click on the link to download the actual .ino file directly.

There's supposedly a speed control wire that goes to the stereo, so I may investigate using that to set up a high speed lockout.

[JayG]

Originally Posted by Polaris

Success!!!

I found the correct final sketch, and I updated it to include a parking brake pin on pin 4.

I'm a little weary about the parking break pin simply because it doesn't require an extra lock-out on the parking brake so it'll operate when somebody presses the button at any speed...in other words, use it at your own risk.

I updated the link to the code in the original post. Also, a side note, the link goes directly to the .ino sketch, but since there is no defined MIME for that extension, it just shows it as text. You should be able to right click on the link to download the actual .ino file directly.

There's supposedly a speed control wire that goes to the stereo, so I may investigate using that to set up a high speed lockout.

You are a Gentleman and a Scholar
the new code works great! :dance:

THANK YOU!!

do you have instructions for connecting for the pbrake interlock?

speed control would be very cool

[Polaris]

Of course, like clockwork, the FTDI Friend just showed up in the mail.

[Polaris]

pBreak should be the same circuit as the other output pins and should wire to the non-grounded side of the parking break switch....which will probably be a pain in the butt to get to.

I had a thought about the safety of the parking brake interlock, only make it activate when putting the top down, since you have the extra step of the top latch, but leave the close interlock as is so you have to click the parking brake handle one click manually. That way you don't accidentally close the top while driving down the highway.

[JayG]

just installed it in my car and it works perfectly

The new code Polaris posted is spot on!

I will look into connecting the p brake later, for now, 1 click is fine

Thanks again Polaris!

BTW, it does not matter which way the transistors are wired as long as you get base correct as they are switching ground

[jb92563]

I just did a "Tortoise Diff" on the Old vs New code and there are lots of differences so don't even try to cut and paste the fixed sections in place in the old one base on the comments here as you WILL miss something.

Better you just redownload the code from the same Link and save the .ino file with date appended so you can get rid of the old incomplete one.

Just saying to help ensure everyones success.

Kudo's to Polaris for developing this and sharing freely with his fellow enthusiasts.

I'm waiting on the speed line upgrade and then I'll jump in as well.

That would be about number 4 on my list of todo's for the 986

[JayG]

Originally Posted by jb92563

I just did a "Tortoise Diff" on the Old vs New code and there are lots of differences so don't even try to cut and paste the fixed sections in place in the old one base on the comments here as you WILL miss something.

Better you just redownload the code from the same Link and save the .ino file with date appended so you can get rid of the old incomplete one.

Just saying to help ensure everyones success.

Kudo's to Polaris for developing this and sharing freely with his fellow enthusiasts.

I'm waiting on the speed line upgrade and then I'll jump in as well.

That would be about number 4 on my list of todo's for the 986

Yes, I saw a bunch of differences as well. Polaris mentioned he muust have origionally uploaded one of the earlier code versions from development

As a FYI, if you are looking at the code and have opened teh link before, you should refresh the cache (scrfeen) as you may be looking at the old code\

in the beginning of the code:

#define openBtnOut 2
#define closeBtnOut 3
#define pBrakeOut 4
#define openBtnIn 8
#define closeBtnIn 9

IF pBrakeOut is not defined, it is the old code

JB, I am in N San Diego, so if you need some help, let me know

[mavis.d]

Having decided to have a go at this I have now got all the bits and down loaded the code to the board and about to start the wiring. I laid all components and wire out and planned when they would go, this is where the problems start. It could be me as never done this type of stuff before, but my board seems to be missing a GND and the + - below is a pic of the board. Any help really appreciated
Cheers
David